This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
categorical
field type [field property version] #68Add a
categorical
field type [field property version] #68Changes from 2 commits
c4bc097
daedf3a
d70253d
734faab
d11abef
fb81a04
ff839dc
440f7c8
7c73f17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like
categories
cannot contain a value that is not present in the data, but I believe we intend the reverse: the field cannot contain a value that is not incategories
. It also seems that the unique constraint should apply whether an array or array of objects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points! Just made some clarifications in the latest commits. Let me know if it looks good or if you have other rephrasings I should try!