Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Alternative changelog representation #60

Merged
merged 16 commits into from
May 7, 2024
Merged

Alternative changelog representation #60

merged 16 commits into from
May 7, 2024

Conversation

roll
Copy link
Member

@roll roll commented Apr 17, 2024

  • Present Table Schema changelog as a list
  • Move up headings and present Table Schema as headings

Copy link

cloudflare-workers-and-pages bot commented Apr 17, 2024

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c44651
Status: ✅  Deploy successful!
Preview URL: https://fc23cdb9.datapackage.pages.dev
Branch Preview URL: https://changelog-alternative.datapackage.pages.dev

View logs

@roll
Copy link
Member Author

roll commented Apr 17, 2024

@peterdesmet
The preview is here - https://changelog-alternative.datapackage.pages.dev/

I think your version is easier to read and easier to go through when e.g. doing an implementation update. BTW I used h5 heading for changes just because it makes it a little bit less gigantic (so I had to introduce a few meaningless heading levels like "Overview/Changes" -- maybe we can just drop them and use ##### directly after ##?)

@peterdesmet
Copy link
Member

I have more commits, where should I push them (since frictionlessdata/datapackage#59 is closed)?

@roll
Copy link
Member Author

roll commented Apr 17, 2024

@peterdesmet
Can you please try pushing to this branch? I had to re-create a PR because Cloudflare doesn't create a preview from forks

@peterdesmet peterdesmet mentioned this pull request Apr 17, 2024
@peterdesmet
Copy link
Member

I don't think I have access rights, I created #61 that (when accepted) merges into changelog-alternative (this PR).

@roll
Copy link
Member Author

roll commented Apr 17, 2024

Thanks! Merged into the branch. BTW I added write access to the Data Package WG on Github so it will be possible to create branches on the repo itself

@peterdesmet
Copy link
Member

All changes are to the CHANGELOG are now completed. Also note there are some minor corrections to other files.

@roll
Copy link
Member Author

roll commented May 7, 2024

We wanted to discuss it in the community call but we ran out of time.

I think the new version a little bit harder to read as a free text (https://changelog-alternative.datapackage.pages.dev/standard/changelog/) compared to the old one (https://datapackage.org/standard/changelog/). I intentionally started sentences from regular words to avoid too much low contrast blocks like this:

low-conrast

But it's the problem with the font color (cc @sapetti9), not with the changelog.


Generally speaking, the new changelog navigation structure is superior so let's merge and then fix the contrast problem

@roll roll merged commit 6d14837 into main May 7, 2024
2 checks passed
@roll roll deleted the changelog-alternative branch May 7, 2024 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants