fix: no longer updates Table while rendering TableHead #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TableHead was calling a context callback during render that caused Table to update and change a state variable. Make sure this does not happend for any value of the "sticky" prop
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/4522-sticky-fail/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Jan 31, 2025
ivarni
requested review from
piofinn,
zenabii,
kristianulv23 and
olejorgenbakken
piofinn
reviewed
Feb 3, 2025
piofinn
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableHead was calling a context callback during render that caused Table to update and change a state variable. Make sure this does not happend for any value of the "sticky" prop
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feilCloses #4522