Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README additions & build fixes #89

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Conversation

DasSkelett
Copy link
Member

@DasSkelett DasSkelett commented Aug 28, 2022

This splits the first chunk from #87, these changes are mostly unrelated with #87.

Changes

  • Some fixes and additions for the README
  • Update rules_python in WORKSPACE to fix building with up to date Bazel releases, in particularly this error:
    $ bazelisk build //wgkex/broker:app
    ERROR: ~/.cache/bazel/_bazel_user/0cb50d472ede3feaa890df93c18ed4c0/external/pip/pypi__flask/BUILD:5:11:
    no such package '@pip//pypi__importlib_metadata':
    BUILD file not found in directory 'pypi__importlib_metadata' of external repository @pip.
    Add a BUILD file to a directory to mark it as a package. and referenced by '@pip//pypi__flask:pypi__flask'
    
  • Unfortunately, this breaks building with the old Bazel version frmo the Docker image (from 2020).
    The upstream Docker image is dead, so now we build our own from the python base image.

Copy link
Member

@awlx awlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@DasSkelett DasSkelett changed the title README & build fixes README additions & build fixes Aug 28, 2022
@awlx awlx merged commit bb26711 into freifunkMUC:main Oct 9, 2022
@DasSkelett DasSkelett deleted the build-fixes branch January 6, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants