Support wgkex loadbalancing/client steering mechanism #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
changed the title
grische
requested changes
Jan 24, 2024
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
DasSkelett
force-pushed
the
wgkex-loadbalancing
branch
from
2fdc688 to
bf1eacc
Compare
grische
requested changes
Feb 2, 2024
There was a problem hiding this comment.
@DasSkelett most comments of mine still hold even after the rebase. Especially the unreachable code should be fixed probably.
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
|
Yes indeed, I only did the rebase so far, which was a necessary step before addressing anything else. I will let you know when I'm ready for another review, I am probably going to mark this PR as "ready for review"/not WIP then, please hold off with further reviews until then, it just makes this more convoluted otherwise. |
DasSkelett
force-pushed
the
wgkex-loadbalancing
branch
from
b17629a to
fd30674
Compare
DasSkelett
changed the title
|
@grische please do one more pass, if it looks good to you I'll reopen this PR upstream |
T0biii
reviewed
Mar 11, 2024
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
grische
requested changes
Mar 14, 2024
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/files/lib/gluon/gluon-mesh-wireguard-vxlan/checkuplink
Outdated
Show resolved
Hide resolved
|
The latest commit also fixes the NTP issues that were caused occasionally be some IPv6 regex mismatch. See freifunk-gluon#96 for details |
grische
force-pushed
the
wgkex-loadbalancing
branch
from
bfd554e to
4bf62bc
Compare
|
Fixed the merge conflicts |
grische
reviewed
Mar 16, 2024
Add support for the server-side loadbalancing with wgkex v0.2.0+ Co-authored-by: DasSkelett <[email protected]>
grische
force-pushed
the
wgkex-loadbalancing
branch
from
4bf62bc to
b82299d
Compare
|
I considerably rewrote the whole function so the integration actually works as intended: This needs a proper re-test. |
grische
force-pushed
the
wgkex-loadbalancing
branch
from
b82299d to
160bb63
Compare
grische
force-pushed
the
wgkex-loadbalancing
branch
from
294d565 to
7710c18
Compare
|
Merged 9fc30b8 |
wusel42
pushed a commit
to ffgtso/community-packages
that referenced
this pull request
Jun 10, 2024
* ffac-wg-registration: add wireguard packages - adds ffac-wg-registration - which communicates with a broker - adds ffac-mesh-vpn-wireguard-openwrt19 - which provides upstream compatible wg functionality for older devices * ffac-mesh-vpn-wireguard-openwrt19: fix public_key * set coorect key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See freifunkMUC/wgkex#87, this is the first draft to implement the client side in checkuplink.
This PR is a placeholder for now, I guess it shouldn't be merged to
mainin the end, which seems to be kept in sync with upstream.Changes
loadbalancing = '1'in site.confIn this case, the
peersoption is no longer needed to be setbrokeroption has changed, it should now only be the base path (withouthttp://scheme prefix and without/suffix) instead of the full path with/api/v1/wg/key/exchangelua-jsoncWill reopen in upstream repo after review.
Closes freifunkMUC/site-ffm#142