Correctly set isHardwareRule in AddHardwareRule #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding hardware rules via
Player.AddHardwareRulesthe argumentisHardwareRulemust explicitly be set to true, because it is false by default. This argument is stored inWireDestConfig.IsHardwareRuleand checked when the hardware rule is removed. If it is not true, the rule is not removed usingPlayer.RemoveHardwareRuleand when using something like MPF that removes and adds the same rules whenever the ball drains, hardware rules will start piling up. With this PR, hardware rules can be removed.