Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanical sound support part 3 #495

Closed
wants to merge 76 commits into from
Closed

Mechanical sound support part 3 #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
73accf8
initial commit
Mr-Jay-Gatsby Feb 13, 2023
00c4fa9
Individual component implements ISoundEmitter, starting with flipper …
Mr-Jay-Gatsby Feb 15, 2023
53e0bb5
Get the component that implements ISoundEmitter for pulling data to t…
Mr-Jay-Gatsby Feb 16, 2023
fc27912
SoundInspector updates including refactor playroundrobin and playrand…
Mr-Jay-Gatsby Feb 16, 2023
e0ba6a0
Further attempt to set pitch shifter value when testing sounds in the…
Mr-Jay-Gatsby Feb 18, 2023
78c0239
sound: Simplify sound asset and move play routine from inspector to a…
freezy Feb 18, 2023
3d4848e
sound: Refactor editor classes.
freezy Mar 1, 2023
f6291d1
sound: Get the runtime working.
freezy Mar 1, 2023
43a8233
sounds: Clean up obsolete stuff.
freezy Mar 1, 2023
54351aa
style: Some comments and re-ordering.
freezy Mar 1, 2023
2d5049b
Minor fix to sound asset, in order to handle when audio clips length …
Mr-Jay-Gatsby Mar 3, 2023
489705d
Initial audio fade implementation.
Mr-Jay-Gatsby Mar 21, 2023
207416d
Updated fade handling. Added sound handling to the following componen…
Mr-Jay-Gatsby Mar 30, 2023
09f4158
fix: UnityEditor reference.
freezy Jan 3, 2024
7b02f2a
implement Stop action
linojon Jan 4, 2024
a5fecdf
Dynamic audiosource for mechanical sound clips
linojon Jan 4, 2024
7612027
populate AudioMixer prop by searching parents
linojon Jan 5, 2024
3a746d9
added target sounds
linojon Jan 5, 2024
0ed3e81
Q to exit play mode
linojon Jan 5, 2024
86bc749
wip drop targets reset and score motor sounds
linojon Jan 8, 2024
c436b1a
trigger switch sounds
linojon Jan 5, 2024
d5cb350
attempt to do target bank reset sound
linojon Jan 5, 2024
3b895c2
Update DropTargetBankApi.cs
linojon Jan 5, 2024
d25ec19
wip drop targets reset and score motor sounds
linojon Jan 8, 2024
491b5c3
button to add MechSound with default volume=1
linojon Jan 30, 2024
25b528a
Apply default values to MechSound instances
arthurkehrwald Nov 25, 2024
b38ae1d
Fix UNT0026 warning
arthurkehrwald Nov 25, 2024
5416805
Remove unused variable
arthurkehrwald Nov 25, 2024
0187995
Do not change open scene when previewing sounds
arthurkehrwald Nov 25, 2024
0ffc529
DropTargetBankComponent doesn't inherit MainRenderableComponent
arthurkehrwald Nov 25, 2024
3bdfed2
Complete score motor sound support
arthurkehrwald Nov 26, 2024
b2fb22b
Rewrite inspectors and sound playback
arthurkehrwald Dec 3, 2024
744f2f8
Reimplement sound fading
arthurkehrwald Dec 5, 2024
db12938
Add invalid sound asset warning
arthurkehrwald Dec 5, 2024
9a82995
Refactor sound playback
arthurkehrwald Dec 7, 2024
07de98b
Minor fixes to SoundsComponentInspector
arthurkehrwald Dec 10, 2024
041eee4
Remove MechSound class
arthurkehrwald Dec 12, 2024
652dc59
Replace UI Toolkit inspector with IMGU
arthurkehrwald Dec 14, 2024
bd63adb
Add interrupt option
arthurkehrwald Dec 14, 2024
f9e24e7
Implement volume correction
arthurkehrwald Dec 14, 2024
f3c37af
Add is spatial option
arthurkehrwald Dec 14, 2024
9e69ae3
Back to UI Toolkit
arthurkehrwald Dec 14, 2024
21c4831
Add interrupt field to SoundComponentInspector
arthurkehrwald Dec 14, 2024
90ae8d1
Code formatting
arthurkehrwald Dec 14, 2024
72e4f38
Tweak SoundComponentInspector margins
arthurkehrwald Dec 14, 2024
e7c5948
Add audio mixer group option to SoundAsset
arthurkehrwald Dec 14, 2024
42beab8
Make SoundTrigger fields readonly
arthurkehrwald Dec 14, 2024
8496ff0
Apply SoundEventArgs.Volume
arthurkehrwald Dec 14, 2024
9ff3a40
Update sound asset inspector tooltips
arthurkehrwald Dec 20, 2024
cc2f716
Break up sound component into base and derived
arthurkehrwald Dec 20, 2024
b642091
Add null check in SoundUtils
arthurkehrwald Dec 20, 2024
1ee54b5
Fix TriggerSoundComponentInspector.GetAvailableTriggers
arthurkehrwald Dec 20, 2024
1c66c52
Null check sound asset before playing
arthurkehrwald Dec 20, 2024
a42489b
Add switch device sound
arthurkehrwald Dec 20, 2024
99e7046
Add hit sound
arthurkehrwald Dec 20, 2024
dfe2de7
Add coil sound
arthurkehrwald Dec 20, 2024
499dd5e
Rename SwitchDeviceSoundComponent
arthurkehrwald Dec 20, 2024
3867aaa
Consolidate event sound similarities into base class
arthurkehrwald Dec 20, 2024
2265b2f
Rename some things
arthurkehrwald Dec 20, 2024
6fd55c4
Remove unused using from HitSoundComponent.cs
arthurkehrwald Dec 20, 2024
dd4be16
Create base class for switch and coil sounds
arthurkehrwald Dec 20, 2024
37d62b2
Derive new NoIdCoilEventArgs from System.EventArgs
arthurkehrwald Dec 22, 2024
2ac12f8
Remove ISoundEmitter
arthurkehrwald Jan 3, 2025
b209165
Remove sound trigger
arthurkehrwald Jan 3, 2025
49be517
Add custom icons for components and sound assets
arthurkehrwald Jan 3, 2025
2d9d197
Remove null audio clips in GetClip
arthurkehrwald Jan 3, 2025
e326a61
Log event source type correctly
arthurkehrwald Jan 3, 2025
df52c75
Init switches and coils in API constructors
arthurkehrwald Jan 3, 2025
401a881
Fix: Set sound event source member
arthurkehrwald Jan 6, 2025
70f36f2
Fix: Use correct enable callback in SoundComponent
arthurkehrwald Jan 6, 2025
062a2eb
Prevent excessive hit sound spam
arthurkehrwald Jan 6, 2025
c1e7f91
Use sound spam protection for all sound types
arthurkehrwald Jan 6, 2025
5ff20d1
Add summary comments
arthurkehrwald Jan 6, 2025
8456345
Fix sound spam warning misfire
arthurkehrwald Jan 8, 2025
e68ddeb
Move sound emitting prefabs to URP and HDRP repos
arthurkehrwald Jan 8, 2025
010ba1d
Lower sound spam detection threshold
arthurkehrwald Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ets/Resources/Prefabs/Plunger.prefab.meta → VisualPinball.Engine/VPT/MechSounds.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added VisualPinball.Unity/Assets/Editor/Icons/small_orange/musical_note.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
114 changes: 114 additions & 0 deletions VisualPinball.Unity/Assets/Editor/Icons/small_orange/musical_note.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added VisualPinball.Unity/Assets/Editor/Icons/small_orange/speaker.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
114 changes: 114 additions & 0 deletions VisualPinball.Unity/Assets/Editor/Icons/small_orange/speaker.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion VisualPinball.Unity/Assets/Presets.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 0 additions & 52 deletions VisualPinball.Unity/Assets/Resources/Prefabs/DropTargetBank.prefab
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions VisualPinball.Unity/Assets/Resources/Prefabs/DropTargetBank.prefab.meta
View file
Open in desktop

This file was deleted.

Loading