Use built-in Ruby debug option vs custom module #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug mode has become less important in recent years since we stopped monkey-patching the test libraries. The only downside I can see for this is that we'll see *all* Ruby debug output when this option is enabled which might obscure Mocha's debug output. However, I think we'll cross that bridge if/when we come to it. I did consider setting `RUBYOPT=-d` in the `environment` entry in `.circleci/config.yml` to replace `MOCHA_OPTIONS=debug`. However, this would've cluttered up the CI build output unnecessarily. Closes #714.
floehopper
deleted the
use-built-in-ruby-debug-option-vs-custom-debug-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug mode has become less important in recent years since we stopped monkey-patching the test libraries.
The only downside I can see for this is that we'll see all Ruby debug output when this option is enabled which might obscure Mocha's debug output. However, I think we'll cross that bridge if/when we come to it.
I did consider setting
RUBYOPT=-din theenvironmententry in.circleci/config.ymlto replaceMOCHA_OPTIONS=debug. However, this would've cluttered up the CI build output unnecessarily.Closes #714.