Skip to content

Commit

Permalink
Remove redundant test name suffixes
Browse files Browse the repository at this point in the history
From `StrictKeywordArgumentMatchingTest`. The fact that the test class
name includes the words "strict keyword argument matching" makes these
suffixes redundant.

These should probably have been removed in this commit [1] in #730.

[1]: eb84bcd
floehopper committed Jan 4, 2025
1 parent 6f51631 commit 63d3854
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/acceptance/strict_keyword_argument_matching_test.rb
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ def teardown
teardown_acceptance_test
end

def test_should_not_match_hash_parameter_with_keyword_args_when_strict_keyword_matching_is_enabled
def test_should_not_match_hash_parameter_with_keyword_args
test_result = run_as_test do
mock = mock()
mock.expects(:method).with(key: 42)
@@ -27,7 +27,7 @@ def test_should_not_match_hash_parameter_with_keyword_args_when_strict_keyword_m
assert_failed(test_result)
end

def test_should_not_match_hash_parameter_with_splatted_keyword_args_when_strict_keyword_matching_is_enabled
def test_should_not_match_hash_parameter_with_splatted_keyword_args
test_result = run_as_test do
mock = mock()
kwargs = { key: 42 }
@@ -37,7 +37,7 @@ def test_should_not_match_hash_parameter_with_splatted_keyword_args_when_strict_
assert_failed(test_result)
end

def test_should_not_match_positional_and_keyword_args_with_last_positional_hash_when_strict_keyword_args_is_enabled
def test_should_not_match_positional_and_keyword_args_with_last_positional_hash
test_result = run_as_test do
mock = mock()
mock.expects(:method).with(1, { key: 42 })
@@ -46,7 +46,7 @@ def test_should_not_match_positional_and_keyword_args_with_last_positional_hash_
assert_failed(test_result)
end

def test_should_not_match_last_positional_hash_with_keyword_args_when_strict_keyword_args_is_enabled
def test_should_not_match_last_positional_hash_with_keyword_args
test_result = run_as_test do
mock = mock()
mock.expects(:method).with(1, key: 42)

0 comments on commit 63d3854

Please sign in to comment.