Model copyright/licenses #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
Superseeds #167, #173
This PR adds a License model, an association to Album and a simple UI for applying a license to an album. I've used @rosschapman's work on modelling and then, inspired by #173, updated the UI code to work with the design changes we've made since that PR was opened.
For now I've made "All rights reserved" the default license for all existing and new Albums. After this PR lands I plan to search through the descriptions of all existing albums and see if I can give them explicit License associations where the artist has indicated they want that license applied.
Thanks to @rosschapman and @floehopper for their contributions to this feature so far. And to @lenikadali who expressed interest in helping to get it finished in Discord and discussed the approached with me.