Prefer a pointer to an incomplete type to void *.

freenode · Aug 28, 2011 · 03cd1dc · 03cd1dc
1 parent bc62eec
commit 03cd1dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/include/entity-validation.h b/include/entity-validation.h
@@ -5,12 +5,12 @@
 #ifndef ENTITY_VALIDATION_H
 #define ENTITY_VALIDATION_H
 
-typedef struct {
+struct entity_chanacs_validation_vtable {
 	chanacs_t *(*match_entity)(chanacs_t *ca, myentity_t *mt);
 	chanacs_t *(*match_user)(chanacs_t *ca, user_t *mt);
 
 	bool (*can_register_channel)(myentity_t *mt);
-} entity_chanacs_validation_vtable_t;
+};
 
 E entity_chanacs_validation_vtable_t *myentity_get_chanacs_validator(myentity_t *mt);
 

diff --git a/include/entity.h b/include/entity.h
@@ -12,14 +12,16 @@ typedef enum {
 	ENT_EXTTARGET,
 } myentity_type_t;
 
+typedef struct entity_chanacs_validation_vtable entity_chanacs_validation_vtable_t;
+
 typedef struct {
 	object_t parent;
 	myentity_type_t type;
 	char *name;
 	char id[IDLEN];
 
 	mowgli_list_t chanacs;
-	void *chanacs_validate;	/* vtable for validating chanacs entries */
+	entity_chanacs_validation_vtable_t *chanacs_validate;
 } myentity_t;
 
 #define entity(x)	((myentity_t *)(x))