refactor(scripts): add typescript to cypress #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @freeCodeCamp/dev-team can you please help review this? |
ojeytonwilliams
previously approved these changes
Sep 2, 2024
|
Did I add my workflows correctly? Edit: Didn't realize I never pushed it. |
|
@ojeytonwilliams do you have a minute to push the changes to the workflow file? |
…odeCamp/news into refactor/add-typescript-to-cypress
ojeytonwilliams
requested changes
Sep 4, 2024
Co-authored-by: Oliver Eyton-Williams <[email protected]>
|
@raisedadead I'm a little out of the loop on news. Can we just merge PRs normally now? |
raisedadead
approved these changes
Sep 4, 2024
|
Yes - there should not be any issues as long as the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #XXXXX
This is a continuation of the PR I struggled to rebase.