This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Fix: run the campaign reports consumer #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm-run-all in package.json (npm start) seems to run the commands sequentially by default, meaning that the campaign reports consumer is never started as it waits for index.js to end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm startdoesn't start the campaign reports consumer, probably leading to some of the issues encountered in #226.It seems that
npm-run-allinpackage.jsonruns sequentially by default, so the feedback consumer is never started (it just waits for server/index.js to finish).This PR just adds the
--parallelflag to thenpm startcommand so both the server and feedback consumer start together.