-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: React.dev docs #2375
feat: React.dev docs #2375
Conversation
Some fixes are still pending but it's looking good already! The only real problem I'm facing is that some |
@simon04 WDYT about the PR's direction? I'm happy to finish it in the coming days. |
Hi @gombosg, thank you for this great work – I love it! Please go ahead and let me know when/where I should help out. Regarding the broken images, simply remove the |
It's ready for review @simon04! It looks good, as per my quality standards. 🤓
Note: React 19 has just been released. We could add it before merging, or we can merge that in a subsequent PR. I'd opt for the latter if possible, as it's more incremental that way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Fixes #1997.
Test with:
bundle exec thor docs:generate react
TODOs:
div
s<figure>
images (base64 is wrong)If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/
directory:16.png
: a 16×16 pixel icon for the doc[email protected]
: a 32×32 pixel icon for the docSOURCE
: A text file containing the URL to the page the image can be found on or the URL of the original image itselfIf you're updating existing documentation to its latest version, please ensure that you have:
SOURCE
file inpublic/icons/your_scraper_name/
are up-to-date if the documentation has a custom iconself.links
contains up-to-date urls ifself.links
is defined