-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix password for SkyFi devices #21
Conversation
@RonFac, can you test this version on your unit? |
Happy to test. Need some guidance on how to go about it.... |
Having problems extracting one of the files sent to me by llowvxe. Norton insists that the file is infected with a trojan.
…________________________________
From: Fredrik Erlandsson ***@***.***>
Sent: Monday, 26 August 2024 5:33 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
@RonFac<https://github.com/RonFac>, can you test this version on your unit?
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4MEXNIITLREIZP5CU3ZTLK4ZAVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGUZTQMJSG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks
…________________________________
From: cremor ***@***.***>
Sent: Monday, 26 August 2024 9:26 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
@RonFac<https://github.com/RonFac> Was that link from one of the deleted comments in #20<#20>? If yes, delete that file! That is malware.
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4LPNIJMQK6CAOQEMXTZTMGEZAVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZHE3TKNBRGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@RonFac here is an example of upgrading pydaikin: home-assistant/core#123160 (comment) This should be the right command:
|
@fredrike Why did you request a review from me for this PR? I'm neither a Python developer (I can barely read/understand Python), nor do I own a SkyFi device. |
Well, I need someone to read the code. You have been active in other parts so I figure you could help me out here. Sorry for the confusion. |
I would love to be able to test. Unfortunately I don't know how to get to the right Linux environment - I am stuck inside the SSH-Core shell.
When I try to execute "Login" at the SSH-core prompt, i do not know the password to proceed.....
Ron
…________________________________
From: Fredrik Erlandsson ***@***.***>
Sent: Tuesday, 27 August 2024 3:54 AM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
@fredrike<https://github.com/fredrike> Why did you request a review from me for this PR? I'm neither a Python developer (I can barely read/understand Python), nor do I own a SkyFi device.
Well, I need someone to read the code. You have been active in other parts so I figure you could help me out here. Sorry for the confusion.
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4JAPCCDAOIIV5U7UNLZTNTUBAVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQG42TCNZSHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me from a pure code perspective
I wrote up a short description on how to debug in hassio: https://github.com/fredrike/pydaikin/wiki/Debugging-from-hassio |
Thanks Fredrike
I managed to run your command and upgrade pydaikin to ver 2.13.4.
Unfortunately no luck....
Here are the debug logs from this configuration:
2024-08-28 20:31:09.701 DEBUG (MainThread) [pydaikin.daikin_base] Updating ['ac.cgi?pass={}', 'zones.cgi?pass={}']
2024-08-28 20:31:09.701 DEBUG (MainThread) [pydaikin.daikin_base] Calling: http://192.168.1.137:2000/ac.cgi?pass={} {} [{}]
2024-08-28 20:31:09.705 DEBUG (MainThread) [pydaikin.daikin_base] Calling: http://192.168.1.137:2000/zones.cgi?pass={} {} [{}]
I have included the terminal screen to verify that I have run the command correctly:
~ # docker exec -it homeassistant pip install ***@***.***
Looking in indexes: https://pypi.org/simple, https://wheels.home-assistant.io/musllinux-index/
Collecting ***@***.***
Cloning https://github.com/fredrike/pydaikin.git (to revision skyfi-pass) to /tmp/pip-req-build-rklorvy2
Running command git clone --filter=blob:none --quiet https://github.com/fredrike/pydaikin.git /tmp/pip-req-build-rklorvy2
Running command git checkout -b skyfi-pass --track origin/skyfi-pass
branch 'skyfi-pass' set up to track 'origin/skyfi-pass'.
Switched to a new branch 'skyfi-pass'
Resolved https://github.com/fredrike/pydaikin.git to commit 897db39
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: netifaces in /usr/local/lib/python3.12/site-packages (from pydaikin==2.13.4) (0.11.0)
Requirement already satisfied: aiohttp in /usr/local/lib/python3.12/site-packages (from pydaikin==2.13.4) (3.10.5)
Requirement already satisfied: urllib3 in /usr/local/lib/python3.12/site-packages (from pydaikin==2.13.4) (1.26.19)
Requirement already satisfied: tenacity in /usr/local/lib/python3.12/site-packages (from pydaikin==2.13.4) (8.5.0)
Requirement already satisfied: aiohappyeyeballs>=2.3.0 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (2.4.0)
Requirement already satisfied: aiosignal>=1.1.2 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (1.3.1)
Requirement already satisfied: attrs>=17.3.0 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (23.2.0)
Requirement already satisfied: frozenlist>=1.1.1 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (1.4.1)
Requirement already satisfied: multidict<7.0,>=4.5 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (6.0.5)
Requirement already satisfied: yarl<2.0,>=1.0 in /usr/local/lib/python3.12/site-packages (from aiohttp->pydaikin==2.13.4) (1.9.4)
Requirement already satisfied: idna>=2.0 in /usr/local/lib/python3.12/site-packages (from yarl<2.0,>=1.0->aiohttp->pydaikin==2.13.4) (3.8)
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable.It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
~ #
…________________________________
From: Fredrik Erlandsson ***@***.***>
Sent: Wednesday, 28 August 2024 6:53 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
I would love to be able to test. Unfortunately I don't know how to get to the right Linux environment - I am stuck inside the SSH-Core shell. When I try to execute "Login" at the SSH-core prompt, i do not know the password to proceed..... Ron
I wrote up a short description on how to debug in hassio: https://github.com/fredrike/pydaikin/wiki/Debugging-from-hassio
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4MMD2UTLCGH3XKVLYDZTWFZ3AVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUG4ZDONJXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
9509c7e
to
7d0bebd
Compare
Replying by email screws with formatting.. It doesn't look like you managed to run the new code. Perhaps you need to remove the daikin integration and then install it again. |
You have missed some flags, it should be:
|
Fredrike
Still no joy.
Here is the terminal screen now:
~ # docker exec -it homeassistant pip install --force --no-deps ***@***.***
Looking in indexes: https://pypi.org/simple, https://wheels.home-assistant.io/musllinux-index/
Collecting ***@***.***
Cloning https://github.com/fredrike/pydaikin.git (to revision skyfi-pass) to /tmp/pip-req-build-fp4grlf8
Running command git clone --filter=blob:none --quiet https://github.com/fredrike/pydaikin.git /tmp/pip-req-build-fp4grlf8
Running command git checkout -b skyfi-pass --track origin/skyfi-pass
branch 'skyfi-pass' set up to track 'origin/skyfi-pass'.
Switched to a new branch 'skyfi-pass'
Resolved https://github.com/fredrike/pydaikin.git to commit 897db39
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pydaikin
Building wheel for pydaikin (pyproject.toml) ... done
Created wheel for pydaikin: filename=pydaikin-2.13.4-py3-none-any.whl size=35078 sha256=0f4e0e337986febb4d71883076bd165cda0cf5820ff7724102d1bd90bb7ba35e
Stored in directory: /tmp/pip-ephem-wheel-cache-089p0tk3/wheels/66/6a/60/77a13ac629d89d1c07699df460d07614b5d2c406beb4325283
Successfully built pydaikin
Installing collected packages: pydaikin
Attempting uninstall: pydaikin
Found existing installation: pydaikin 2.13.4
Uninstalling pydaikin-2.13.4:
Successfully uninstalled pydaikin-2.13.4
Successfully installed pydaikin-2.13.4
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable.It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
~ #
The DEBUG logs are identical to previous ones.
…________________________________
From: Fredrik Erlandsson ***@***.***>
Sent: Wednesday, 28 August 2024 8:59 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
~ # docker exec -it homeassistant pip install @.***
You have missed some flags, it should be:
docker exec -it homeassistant pip install --force --no-deps ***@***.***
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4LJEFA3237QLQC4AO3ZTWUS5AVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUHE4TOOBVGU>.
You are receiving this because you were mentioned.
|
Hm, I wonder what happens after you have installed the fixed pydaikin.. Did you remove and add your device? |
I deleted my Daikin device and attempted to re-install it - I get this error screen:
[cid:9be6cc86-dc6f-46f5-b69f-a77818d5dc70]
From previous experience, I know that it will only allow me to recreate the Daikin installation if I regress to 2024.7.4
Ron
…________________________________
From: Fredrik Erlandsson ***@***.***>
Sent: Wednesday, 28 August 2024 9:17 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
Hm, I wonder what happens after you have installed the fixed pydaikin..
Did you remove and add your device?
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4LULIPONCFGI2UGQ5TZTWWS5AVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVGAZTGMBUGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Here is the error screen: These are the latest logs captured during my attempt to re-install the integration: 2024-08-28 21:13:22.698 DEBUG (MainThread) [pydaikin.daikin_base] Updating ['ac.cgi', 'zones.cgi'] |
Maybe it's nothing, but I noticed this DEBUG log |
Great! We are running the latest code.
Now we just need to figure out why it's not working ;). |
Is the program trying to connect to a BRP069 ? SkyFi is BRP15A61. For all I know, BRP069 is not set up with a password,,,,, |
Yes that is strange. But it looks like you first tried with "correct" password, then I've updated the code so please try the |
Latest logging with new version: 2024-08-28 22:13:50.582 DEBUG (MainThread) [pydaikin.daikin_base] Updating ['ac.cgi', 'zones.cgi'] |
Nope, that is not the latest code, please hookup here: https://community.home-assistant.io/u/fredrike |
I ran the same command as before: " docker exec -it homeassistant pip install --force --no-deps git+https://github.com/fredrike/pydaikin.git@skyfi-pass " Should that not have downloaded the latest pydaikin ? |
@RonFac new version available.. this might be faster to test:
That gives me this:
Exception
|
This is what I got on the terminal screen: docker exec -it homeassistant sh -c 'pip install --no-deps --force \
I will sign off now - It's late in Sydney. Thanks for your time... |
Wow, that's great! It seems like it is working now. All it took was a little more exception-handling and retries.
That's strange, but it looks like you are running the old version again ( I'll merge this and create a new version for HomeAssistant. |
I have followed the above and it works and initlises however when I try and use any function in HA under entities it shows an error (attached) have tried restarting home assist and uninstalling and re installing via script Failed to perform the action switch/turn_on. Unexpected HTTP status code 500 for http://192.168.1.209:2000/set.cgi?p=0&t=20.0&f=3&m=8&pass=72102 |
@ciaran4thank you for finding this. I guess there were a reason why we did retries even for clien response errors. I'll see what I can do to fix it. The error I'd due to the bad quality of the skyfi module. |
@fredrike haven't had any time to help out with these issues of late but if retry is all we are after the |
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: kingy444 ***@***.***>
Sent: Thursday, August 29, 2024 2:39:48 PM
To: fredrike/pydaikin ***@***.***>
Cc: RonFac ***@***.***>; Mention ***@***.***>
Subject: Re: [fredrike/pydaikin] Fix password for SkyFi devices (PR #21)
@ciaran4thank you for finding this. I guess there were a reason why we did retries even for clien response errors. I'll see what I can do to fix it.
The error I'd due to the bad quality of the skyfi module.
@fredrike<https://github.com/fredrike> haven't had any time to help out with these issues of late but if retry is all we are after the tenacity module should be able to handle that with its @Retry<https://github.com/Retry> decorator
—
Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A543C4NQ7VCWC25SJEYS7TTZT2QZBAVCNFSM6AAAAABNDOBNFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWG4YDAOJUHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
.........................................................................................................................................
Join online meeting<https://join.skype.com/ro3mgTfTcOjE>
.........................................................................................................................................
|
I rather not, I have an iPhone.. |
Fixes: #20
Related to: home-assistant/core#124095