Add permissions section and integration job #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackptr
force-pushed
the
corey/integration-test
branch
from
41e1744 to
5e7e851
Compare
stackptr
commented
Nov 2, 2023
|
|
||
| integration: | ||
| runs-on: ubuntu-latest | ||
| permissions: {} |
There was a problem hiding this comment.
This job should fail when an action using this template does anything more than checkout a repo (which works, incidentally, with no permissions, because it is a public repo).
pbrisbin
approved these changes
Nov 2, 2023
|
Please remove me from all these non-megarepo things. I have no further need for this information. |
|
Corey and Pat, it was a pleasure working with you both btw! |
|
Likewise @xave. I believe you getting notified of things you're not participating in is a you-side setting:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a section in the README and an
integrationjob to the CI workflow to motivate future uses of this template to specify the minimal permissions required to run the action. This is good to have when workflows are triggered by Dependabot or are otherwise run in repositories with less permissive defaults for workflow runs.See also: freckle/commenter-action#401