Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetchWithLinks and parser dependency #1

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

stackptr
Copy link
Member

fetchWithLinks is used by only a single Freckle application and depends on @freckle/parser. This domain-specific function should be moved into the application requiring it.

`fetchWithLinks` is used by only a single Freckle application and depends on `@freckle/parser`. This domain-specific function should be moved into the application requiring it.
@stackptr stackptr requested a review from joris974 January 17, 2024 00:23
@stackptr stackptr self-assigned this Jan 17, 2024
Copy link

PR checklist

  • Flow interfaces in lib/ have been updated to reflect changes in .d.ts interfaces, if any.
  • Version in package.json is updated according to semver policy.
  • Built dist/ reflects all changes in PR prior to merge.

@stackptr
Copy link
Member Author

FWIW, I only found one reference to this function in megarepo:

platform/console/src/helpers/api-school-admins.js
5:import {fetchWithLinks, type LinksT} from '@freckle/ajax'
25:  return fetchWithLinks<Array<DetailedSchoolAdminT>>(url, array(schoolAdminAttrsParser))

@stackptr stackptr merged commit d99e320 into main Jan 17, 2024
1 check passed
@stackptr stackptr deleted the remove-parser-dep branch January 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants