Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch shift details and save for all shift types #2709

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

asmitahase
Copy link
Collaborator

Problem

Fetch shift would fetch shift details and save if newly fetched shift was different. This would prevent logs from updating with shift details if the shift settings were changed.

Fix

  • Removed same shift check on fetch shift call
  • Added a test

@asmitahase asmitahase merged commit bd2e1f5 into frappe:develop Jan 27, 2025
7 checks passed
asmitahase added a commit that referenced this pull request Jan 27, 2025
…2709

fix(Employee Checkin): Fetch shift details and save for all shift types (backport #2709)
asmitahase added a commit that referenced this pull request Jan 27, 2025
…2709

fix(Employee Checkin): Fetch shift details and save for all shift types (backport #2709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant