-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spaces #345
base: main
Are you sure you want to change the base?
feat: Spaces #345
Conversation
Spaces is nice. When you get to like 30 spaces, there will be some grouping / classification required. You already see this in Telegram, WhatsApp (communities) etc. Maybe in the "All Spaces" section, allow for groups? |
I would try to avoid hierarchy. It doesn't end up being good enough UX on the side bar or on cell phones. Maybe best to make use of tags to classify and group spaces. This way, you can maintain an overview, while also navigating the app with filters to focus on the currently relevant stuff. If somebody really needs to encode their org structure into this app (maybe to manage access rights?), tags could contain a Access rights could then be given based on tags, in addition to individual spaces / pages. I'm not entirely clear whether to suggest tags (m2m) or category (o2m), here. Maybe start with a simpler o2m and expand to m2m only if necessary? Thoughts? |
cdad21d
to
915a4e5
Compare
gameplan Run #338
Run Properties:
|
Project |
gameplan
|
Branch Review |
refs/pull/345/merge
|
Run status |
Failed #338
|
Run duration | 01m 59s |
Commit |
2691c4ada5 ℹ️: Merge d1c0fc1e046c9bb89f7dac50432abe2e26c17965 into 2948256ddb1ddfce3717158c349f...
|
Committer | Faris Ansari |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
View all changes introduced in this branch ↗︎ |
Tests for review
comment.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
Comment > comment actions |
Screenshots
Video
|
discussion.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
Discussion > all discussion actions |
Screenshots
Video
|
team.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
Team > team creation, readme edit and archive |
Screenshots
Video
|
- join/leave actions - create new space
- refactor sidebar code into composition api
- refactor into composition api - groupedSpaces data utility
- useDiscussions helper - DiscussionRow component - simplify Discussions component - new tabs: Following, Participating, All - NewDiscussion page - show pinned discussions at the top
- Space List - Space Discussions - Space Pages - Space Tasks - PageHeader component
Actions dropdown for a space
- render discussion using only spaceId and postId prop
via frappe-ui
- update implementation of beforeEach
- join all space - leave all spaces - edit category title - delete space - create new space in category
- hide pinned in other views
For the longest time, the rigid structure of Team > Project has bugged me. There are some issues with this.
There is a need to simplify.
This is a new direction I am exploring for Gameplan:
gameplan-spaces-pr-demo.mov
Other changes in PR:
<script setup lang="ts">
Todo:
Rename GP Team to GP CategoryRename GP Project to GP SpaceDepends on https://github.com/netchampfaris/frappe/tree/api-v2-fixes