Audit/issues #23
Audit/issues #23
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 76dca74 in 1 minute and 28 seconds
More details
- Looked at
86lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. backend/index.ts:76
- Draft comment:
Typo in console log message: 'recieved' should be 'received'. This typo is present in multiple places. - Reason this comment was not posted:
Confidence changes required:50%
The console log message has a typo in 'recieved'. This typo is present in multiple places and should be corrected for clarity and professionalism.
2. backend/index.ts:77
- Draft comment:
Typo in console log message: 'recieved' should be 'received'. This typo is present in multiple places. - Reason this comment was not posted:
Confidence changes required:50%
The console log message has a typo in 'recieved'. This typo is present in multiple places and should be corrected for clarity and professionalism.
Workflow ID: wflow_y4YaxvfAJW3OuY4A
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const DEPLOYED_SERVER_URL = 'https://algorithm-visualisations-express-production.up.railway.app' | ||
|
|
||
| async function selectServerUrl() { | ||
| const hasNetworkConnection = await axios({ |
There was a problem hiding this comment.
The network connectivity check is incorrect. hasNetworkConnection will always be truthy if the request doesn't throw an error. Consider using a try-catch block to handle errors and determine connectivity.
| } | ||
|
|
||
| // It's not clear to me why this promise is getting rejected? | ||
| const TEST_URL = selectServerUrl() |
There was a problem hiding this comment.
TEST_URL is assigned a promise instead of the resolved value. Use await selectServerUrl() to get the resolved value.
| const TEST_URL = selectServerUrl() | ||
| console.log('server', TEST_URL) | ||
|
|
||
| const SERVER_URL = 'http://localhost:8080' |
There was a problem hiding this comment.
SERVER_URL is hardcoded to 'http://localhost:8080'. Consider using the result from selectServerUrl() to dynamically set the server URL based on connectivity.
Important
Improves logging and adjusts code comments for selection sort and server URL logic in backend and frontend.
index.tsfor selection sort and DFS routes to include request and response details.express.tsto check server accessibility.selectionSort.ts.SelectionSort.tsxto referenceselectionSortinstead ofbubbleSort.selectServerUrlfunction inexpress.tsto dynamically choose between deployed and local server URLs based on network connection.This description was created by
for 76dca74. It will automatically update as commits are pushed.