Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container image support #1000

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jan 22, 2025

This PR adds container image support to dissect in the form of a loader and filesystem. It implements the Docker image spec and OCI container image spec.

Example usage:

$ docker pull python:latest && docker image save python:latest -o image.tar
$ target-shell image.tar
debuerreotype:/$ ls
$fs$
bin
boot
dev
etc
home
lib
lib64
media
mnt
opt
proc
root
run
sbin
srv
sys
tmp
usr
var
debuerreotype:/$ python
In [1]: t.fs.mounts["/"]
Out[1]: <ContainerImageFilesystem path=/tmp/image.tar name=python:latest>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature fits better when entirely implemented as a loader, rather than a loader and a separate filesystem. I don't think I see anything unique in the filesystem implementation that can't be handled in the loader, but correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants