Add default settlement data to "add-settlement" handler in kingdom sheet #18134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eet to avoid sheet crashing due to missing consumption value
MaximMukhanov
changed the title
|
I'll dig into this soon and see if we can't solve this by using default values, but if I can't get something clean I'll simply merge this in. Thank you for looking into it. |
|
No problem, thank you for working on system! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents kingdom sheet crash on adding settlement due to the lack of settlement data in "add-settlement" handler.
foundryvtt/foundryvtt-premium-content#898 - issue in foundry premium modules repo that explains the problem.