Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AELikes to work on the parent item #18126

Closed
wants to merge 1 commit into from

Conversation

Cerapter
Copy link
Contributor

As the title says, extends the AELike Rule Element with an additional field called target. Defaults to "actor", where it behaves just as it does now, but if set to "item", it'll instead look for and modify the path on the RE's parent item.

Gonna be honest, this one is purely self-serving. I just wanna place flags on items without needing to use a macro.

@CarlosFdez
Copy link
Collaborator

CarlosFdez commented Jan 28, 2025

If I remember correctly, ItemAlteration was created specifically to avoid AELikes targetting items. Do Foundry ActiveEffects target items?

@MrVauxs
Copy link
Contributor

MrVauxs commented Jan 28, 2025

If I remember correctly, ItemAlteration was created specifically to avoid AELikes targetting items. Do Foundry ActiveEffects target items?

Pretty sure they do, D&D5e has that with Enchantments.

@stwlam
Copy link
Collaborator

stwlam commented Jan 28, 2025

We're definitely trying to move away from AE-likes. What problem does this attempt to solve? There is no corresponding issue, and the PR has no context.

@Cerapter
Copy link
Contributor Author

There is no corresponding issue because there is no problem it's trying to solve (as far as I'm aware), flags on items would just be really useful for homebrewing stuff.
However, I can vibe with doing it with ItemAlteration, and there are a few (actually useful to the project) things I wanna do with ItemAlteration, so I'll make a PR for that.

@Cerapter Cerapter closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants