Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Crunch to use DamageAlteration #18122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MrVauxs
Copy link
Contributor

@MrVauxs MrVauxs commented Jan 26, 2025

No description provided.

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Jan 26, 2025

https://discord.com/channels/880968862240239708/880969241552113695/1333195126021029979

Turns out this doesn't solve the issue that spurred this PR (interaction between Animal Instinct (Wolf) and the Crunch feat overriding each other), as DamageAlteration just upgrades to a higher number regardless of whether the existing one is above or below.

@MrVauxs MrVauxs changed the base branch from Custom-Heritage to master January 26, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants