[#5037] Add units display to ranged communication pill #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roth-michael
force-pushed
the
communicationRangeUnits
branch
from
6051584 to
7359de8
Compare
roth-michael
force-pushed
the
communicationRangeUnits
branch
from
7359de8 to
2d92f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5037
Changes pill under Languages to display units alongside any ranged communication (currently only telepathy):
Senses also accept multiple units, but as they're more likely to almost always be whatever the "default" unit of measure is (feet, typically) it doesn't make much sense to give them this same functionality. Maybe specifically for non-feet, non-meter units. But that'd be a different PR.