[#2678] Fix "Reveal" button in secret blocks in multi-editor #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issues with reveal buttons for secret blocks for items and actors that use multiple description editors. This required overriding `_getSecretContent` and `_updateSecret` to look for `data-target` in addition to `data-edit`. The locking code was also modified to avoid disabling the secret button when the sheets are in play mode. There is a still a bug with the PC sheet and the item sheets with only a single description (like classes), which don't retain the secret state if the play/edit toggle is changed immediately after changing the secret state. This appears to be because when it submits `FormDataExtended` is fetching old data from the editor instances on the sheet. Closes #2678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues with reveal buttons for secret blocks for items and actors that use multiple description editors. This required overriding
_getSecretContentand_updateSecretto look fordata-targetin addition todata-edit. The locking code was also modified to avoid disabling the secret button when the sheets are in play mode.There is a still a bug with the PC sheet and the item sheets with only a single description (like classes), which don't retain the secret state if the play/edit toggle is changed immediately after changing the secret state. This appears to be because when it submits
FormDataExtendedis fetching old data from the editor instances on the sheet.Closes #2678