[#4619] Increase "Add X" button visibility in activity sheets

[roth-michael]

Would close #4619

Open to suggestions re: styling (definitely needs some improvement, I think - e.g. "Create Effect" not being centered; but I didn't center it because I kind of think it looks better that way) and I reused the tooltip i18n but considered creating an Add-type localization instead.

Consumption tab:

Attack "Effect" tab:

Damage "Effect" tab:

Enchanting tab:

Save "Effect" tab:

Summoning tab:

[thatlonelybugbear]

How about alinging it to the right, or even reusing the same system's Create New XXX + buttons, which are already present in different places? 🤔

[roth-michael]

Not sure I'm a fan of right-aligned. But dunno, really. As for the localization, what such buttons are you thinking of? Outside of activities, it's almost all handled via the little gold "create child" square buttons at the bottom right of the sheet, which are unlabeled.

[thatlonelybugbear]

Yeah I meant exactly those ones without a label (well maybe a hint on hover).

It already has made it in the UI in different places and probably would make sense to users without the need of the actual text, which I am not a fan of TBH 🤷

[roth-michael]

I see - so like this:

Not entirely sold on that, lotta blank space.

[roth-michael]

Aligning to the left and giving 2px top margin:


That's feeling better to me.

[arbron]

Centered version is basically what I used on Black Flag:

[roth-michael]

I think part of the issue with just centered is that without the dotted line you've got in that screenshot (which might not fit in with 5e's styling), when it follows text like the "allow critical" hint it looks a bit strange. Aligning to the left makes it look a lot more natural in that instance, I think.

[arbron]

Make sure you update the "Create Recovery Profile" button on item sheets to match.

The color for the button in light mode seems a bit too light, feels like it is disabled, but I'll leave any color decision to Kim.

[arbron]

@roth-michael Give the original issue a comment so I can assign it to you :)