Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2094] Move actor data preparation into data models #4909

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Dec 19, 2024

Moves skill, tool, armor class, initiative, spellcasting ability, condition immunity, and scale value preparation into data models. This leaves only spellcasting preparation in the main actor class.

@arbron arbron added the api label Dec 19, 2024
@arbron arbron added this to the D&D5E 4.2.0 milestone Dec 19, 2024
@arbron arbron requested a review from Fyorl December 19, 2024 23:17
@arbron arbron self-assigned this Dec 19, 2024
@arbron arbron modified the milestones: D&D5E 4.2.0, D&D5E 4.3.0 Jan 20, 2025
Moves skill, tool, armor class, initiative, spellcasting ability,
condition immunity, and scale value preparation into data models.
This leaves only spellcasting preparation in the main actor class.
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

module/data/actor/templates/attributes.mjs Outdated Show resolved Hide resolved
@arbron arbron changed the base branch from 4.2.x to 4.3.x January 28, 2025 14:08
@arbron arbron merged commit 1e24fd9 into 4.3.x Jan 28, 2025
@arbron arbron deleted the actor-data-prep branch January 28, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants