Secret block "Reveal" button is non-functional in MultiEditor #2678
Comments
|
I have encountered this as well. Here is where secrets.js is unable to find
Here is a sample of what the DOM looks like where the secrets code is checking:
|
|
The reveal secret button is also locked whenever the sheet is locked, so it currently doesn't work either for items without the multi-editor. |
arbron
added a commit
that referenced
this issue
Jan 11, 2025
Fixes the issues with reveal buttons for secret blocks for items and actors that use multiple description editors. This required overriding `_getSecretContent` and `_updateSecret` to look for `data-target` in addition to `data-edit`. The locking code was also modified to avoid disabling the secret button when the sheets are in play mode. There is a still a bug with the PC sheet and the item sheets with only a single description (like classes), which don't retain the secret state if the play/edit toggle is changed immediately after changing the secret state. This appears to be because when it submits `FormDataExtended` is fetching old data from the editor instances on the sheet. Closes #2678
arbron
added a commit
that referenced
this issue
Jan 21, 2025
Fixes the issues with reveal buttons for secret blocks for items and actors that use multiple description editors. This required overriding `_getSecretContent` and `_updateSecret` to look for `data-target` in addition to `data-edit`. The locking code was also modified to avoid disabling the secret button when the sheets are in play mode. There is a still a bug with the PC sheet and the item sheets with only a single description (like classes), which don't retain the secret state if the play/edit toggle is changed immediately after changing the secret state. This appears to be because when it submits `FormDataExtended` is fetching old data from the editor instances on the sheet. Closes #2678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clicking Reveal silently fails in Item Description with multieditor
RevealYourself.webm
Also, should the Reveal button display when an Item is expanded as well as in the Item Sheet?
Some tables do give Observer access to all their party's actors, so there may be an instance where a player wants to hide information about an Item or Feature from the other players, but still be able to easily reveal it later on
The text was updated successfully, but these errors were encountered: