Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup/basic project setup #12

Merged
merged 12 commits into from
Apr 15, 2019
Merged

Setup/basic project setup #12

merged 12 commits into from
Apr 15, 2019

Conversation

ali-7
Copy link
Contributor

@ali-7 ali-7 commented Apr 14, 2019

relates to #10

project setup/ file structure

  • create-react-app
  • elsint-configration
  • add-styled-components-package
  • travis-configuration
  • code-coverage-configration

Copy link
Contributor

@teenie-quaggard teenie-quaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@ali-7 ali-7 self-assigned this Apr 14, 2019
@ali-7 ali-7 requested review from teenie-quaggard and removed request for Oliversw, hshahwan and teenie-quaggard April 14, 2019 19:30
@ali-7 ali-7 mentioned this pull request Apr 14, 2019
@Oliversw
Copy link
Contributor

Looks great! Thanks!

@ali-7 ali-7 requested review from hshahwan and Oliversw April 15, 2019 11:06
@ali-7 ali-7 merged commit 038f705 into master Apr 15, 2019
@ali-7 ali-7 deleted the setup/basic-project-setup branch April 15, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants