-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block qtype for a given engine if not implemented #500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 30 30
Lines 895 895
=======================================
Hits 822 822
Misses 73 73 Continue to review full report at Codecov.
|
@realslimshanky @umangahuja1 please review. |
Looks good to me. Can you share deployed app to test in real time? |
https://aqueous-refuge-13068.herokuapp.com/ ,Its in the description as well 😃 |
Oops missed it 😅 |
Please dont search in preview link with parsijoo. It crashes the app.... #498 . Already made a PR to resolve it. |
Yeah I found that parsijoo news is not working. So we should disable it. |
@umangahuja1 no try search |
Yeah you are right. So it's good that this issue is already being handled. |
Please approve if it's looks good to you 😀 |
I don't know how this project takes my approval though. Let's wait for someone more experienced here 😄. |
@umangahuja1 no problem, you have to go to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue claimed is resolved in this PR.
Though some news engines like parsijoo and bing need to be addressed separately to resolve crashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the idea is good, few endpoints have to be considered in order to fix it completely. For example,
- When you select an engine which has video enabled say
Bing
, you click on the video and then you selectGoogle
whose video button is disabled, but the previous selection remains intact and doesn't go to default button i.e.general
.
Nice catch, on it |
Updated now, preview link too updated. @realslimshanky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #499
Checklist
master
branch.Changes proposed in this pull request:
Preview link: https://aqueous-refuge-13068.herokuapp.com/
disable
qtype for a given engine.google
search engine, i.e. all exceptgeneral
disabled.