-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #455 Add Image/Video search support for Parsijoo #449
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
70899f8
Addresses #320 and #321 Add Image/Video search support for Parsijoo
bhaveshAn afc397d
Resolve conflicts
bhaveshAn 6ff5499
Merge remote-tracking branch 'upstream/master' into parsijoo-image
bhaveshAn ea4618f
Add staticmethod decorator
bhaveshAn 5692c94
Add staticmethod decorator
bhaveshAn e80eaeb
Add staticmethod decorator
bhaveshAn 7c17a89
Add staticmethod decorator
bhaveshAn 5251491
Add staticmethod decorator
bhaveshAn cea1408
Add staticmethod decorator
bhaveshAn c5b0397
Add staticmethod decorator
bhaveshAn 8f47338
Add staticmethod decorator
bhaveshAn 40e5246
Add staticmethod decorator
bhaveshAn 1e865a9
Add staticmethod decorator
bhaveshAn 3df4a23
Resolved conflicts
bhaveshAn c37af57
Add tests
bhaveshAn ac01b4b
Resolved conflicts
bhaveshAn d45d132
Merge branch 'master' into parsijoo-image
bhaveshAn 8d328d9
Merge branch 'master' into parsijoo-image
bhaveshAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cclauss
Can't be done to for this reason. Its exceeding the default
max-line-length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat as for div in soup.find_all('div', class_='image-container overflow'): to avoid the backslash and the long line. Both are advised against in PEP8.