-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed materialshowcase libary due to crash on android 10 #2934
Conversation
@iamareebjamal @yashk2000 Please check and merge! |
@iamareebjamal Please get this done |
Should have replaced with some other library |
@iamareebjamal Shall I do this in this PR or another issue? |
Why would I merge a PR on which I have requested changes and which would leave the app in a broken state? |
Why should this leave the app in broken state? It has removed the library but not replaced with some other, but didn't broke anything. @iamareebjamal |
That's called broken. Every commit of the repo should have correct build of app. This is clearly incomplete work, so should not be merged as a commit, regardless of if it breaks something or not. If you just add a blank activity and say nothing is broken, and I'll add UI in another PR and logic in yet another PR, none of those PRs should be merged because the feature is incomplete and if the user will compile the app from a particular commit, he/she'll get an incomplete app, doesn't matter if the app crashes or not |
@iamareebjamal Okay sending the PR asap |
@iamareebjamal Check this now |
Fixed #2930
Changes: Removed material showcase library
Screenshots of the change: