-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Pinterest Auth with upload #2892
base: development
Are you sure you want to change the base?
Conversation
I am testing and facing too many request on pinterest server, so will complete this PR by tomorrow and also I will fix failing build and few bugs, |
@yashk2000 @iamareebjamal I am stucked here from 2 days. I am uploading the image through multipart, i recieve error. I tried as they did implemented in pdk client, but that doesn't also works. I am getting failure with multipart. will update here |
@iamareebjamal @yashk2000 Need your help, I am trying to call uploadimage api to pinterest The curl call is
My function to create body in android is using volley
The postman call works fine, I am not getting what's the issue |
Please help me, I am stucked and not getting solution. I need to complete this last step to get the Pinterest account section get working. |
I have no experience with volley. Only with OkHttp and Retrofit |
@codedsun can you please explain why we have to use volley here? can't we go with retrofit ? |
@prudhvir3ddy The project is using volley, not retrofit for api calls. If i would have used retrofit, might be the task would have been done |
@iamareebjamal @prudhvir3ddy We are using a volley library that has been depreciated https://github.com/mcxiaoke/android-volley What shall I do now? |
Move to Retrofit |
Moving to retrofit #2895 |
@codedsun if the work related to this pr has been done, should I close it? |
No it will be completed by tomorrow. Getting some issues in image uploading.
…On Sun, Nov 3, 2019, 6:25 PM Yash Khare ***@***.***> wrote:
@codedsun <https://github.com/codedsun> if the work related to this pr
has been done, should I close it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2892?email_source=notifications&email_token=AEYZISEB7JZ3FNEMXWDQUVTQR3C3VA5CNFSM4JASKAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5R5IQ#issuecomment-549133986>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYZISANW73D2QVFNIOCWNDQR3C3VANCNFSM4JASKAZA>
.
|
1e9a194
to
76030ee
Compare
@yashk2000 The work has been completed, please check Also @iamareebjamal We need to get the secret key from app created on pinterest developer console and also a Pinterest_Auth State and redirect URI. These fields are to be kept same as that saved in developer console. Thanks. |
Make it so that if the keys are not present, the app doesn't crash |
@iamareebjamal Done! @yashk2000 Please check |
@yashk2000 Please check |
@yashk2000 Also chcek this |
Fixed #2292
Changes: Removed pdk client and added api endpoints for OAuth and upload
Screenshots of the change: