Fix: Prevent automatic charset=utf-8 addition to Content-Type headers #631
Conversation
This change prevents the HTTP package from automatically appending 'charset=utf-8' to Content-Type headers by: Using low-level http.Request instead of high-level client methods Setting request.bodyBytes directly with UTF-8 encoded content Preserving exact Content-Type headers as specified by users This ensures users have full control over Content-Type headers sent to servers, addressing issues where some APIs reject requests with charset parameters.
- Add support for multiple character encodings using charset package - Implement mapping for all IANA standard charsets to their Dart equivalents - Fix mismatch between Content-Type header charset and actual body encoding - Support UTF-8, UTF-16, UTF-32, ISO-8859 variants, Windows code pages, and Asian encodings - Provide appropriate fallbacks for less common encodings - Add proper content type detection and encoding for request bodies - Improve error handling for unsupported encodings
| final normalizedName = charsetName.toLowerCase().trim(); | ||
|
|
||
| // Direct codec mappings - built-in encodings first | ||
| switch (normalizedName) { |
There was a problem hiding this comment.
What is the source of this codec map and names?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think we don’t need this much but I have just added it we can remove them also
There was a problem hiding this comment.
@AffanShaikhsurab Where in the link that you provided are the strings iso646-us & iso_8859-1:1987 that was written below in the case matching?
Kindly do not beat around the bush and tell exactly how you got all the string cases.
There was a problem hiding this comment.
@ashitaprasad I initially thought that the ISO encoding was present in the list of supported encodings, but upon further inspection, I realized it was not included in the updated code. I have now ensured that only the encoding types available in the dart:convert package and Flutter’s Charset are used.
I have a question: should we first encode it as UTF-8 and then pass it as text/csv in the content headers , is this the expected behaviour ?
Apologies for the earlier oversight—I was working on multiple issues simultaneously, which led to an incomplete implementation. I will ensure that I take on fewer tasks at a time and implement them more carefully moving forward.
|
and for the |
PR Description
This change prevents the HTTP package from automatically appending 'charset=utf-8' to Content-Type headers by:
This ensures users have full control over Content-Type headers sent to servers, addressing issues where some APIs reject requests with charset parameters.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?