feat:env variables support #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashitaprasad does this approach have any issue |
| @@ -0,0 +1,136 @@ | |||
| import 'package:flutter/material.dart'; | |||
There was a problem hiding this comment.
Why are you duplicating the widget and not modifying the EnvironmentTriggerField code?
There was a problem hiding this comment.
@ashitaprasad trigger field was small as itself and didnt had multiple line support but i felt like changing the existing field code can make it less readable .
| import 'package:apidash_core/apidash_core.dart'; | ||
| import 'package:apidash_design_system/apidash_design_system.dart'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | ||
| import 'package:apidash/providers/providers.dart'; | ||
| import 'package:apidash/widgets/widgets.dart'; | ||
| import 'package:apidash/consts.dart'; | ||
| import '../../../../common_widgets/envfield_editor.dart'; |
There was a problem hiding this comment.
@ashitaprasad my bad would resolve it
|
@ashitaprasad I have removed the duplicated widget upon your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Trying to use enviornment variables in JSON and Text
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?