Initial working xwwwurlencoded body type #567
Open
+353
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second option provided in this comment will be more user friendly |
Screen.Recording.2025-02-21.at.2.17.36.PM.movHere is the POC for this approach. Just need to figure out where to put this switch as it looks so out of place here. |
WrathOP
force-pushed
the
feat-urlencoded-body
branch
from
1cc5d50 to
f15bb77
Compare
The POC looks good @WrathOP 👍 |
|
You can cleanup the code and let me know when it is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implemented a basic POC for the xwwwurlencoded body content by adding an option to send it seperate from already implemented formdata. I think doing it this way is better as the discussed way of sending by default url encoded and sending multipart when a file is attached can lead to confusions and also if the user specificly wants to send a multipart. If we are adding a toggle for these 2 it will create a sort of divide in the type of the body type where you will have a different variable of sorts to know what kind of body this is. Anyways open to suggestions.
Related Issues
Screen.Recording.2025-02-11.at.8.11.46.PM.mov
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
I'll add tests in further development after the POC is approved
OS on which you have developed and tested the feature?