Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Web_Socket_Support #555

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat:Web_Socket_Support #555

wants to merge 25 commits into from

Conversation

Clasherzz
Copy link
Contributor

PR Description

The PR discusses an approach for adding websocket support to API Dash.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • [] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

I haven't yet added test cases and would like to have some support for that

  • [] Yes
  • No, and this is why: needs help and support

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

@Clasherzz Clasherzz marked this pull request as draft February 1, 2025 04:42
@Clasherzz Clasherzz marked this pull request as ready for review February 1, 2025 05:45
@Clasherzz
Copy link
Contributor Author

Clasherzz commented Feb 1, 2025

image
image

@Clasherzz
Copy link
Contributor Author

Clasherzz commented Feb 1, 2025

@ashitaprasad I haven't finished on the history part of websocket (there is an error throwing because of this I would work on this once the approach is reviewed) . And still trying to make the scrolling functionality bit more smoother. Currently the new frames are pushing the old frames down , making it hard for tester to read when multiple frames comes fastly.

@Clasherzz
Copy link
Contributor Author

@ashitaprasad apart from above mentioned issues the branch is ready to review .

@opheliagame
Copy link

@Clasherzz hi, looked briefly at your PR and noticed that you have commited some generated files as well. The model files generated by the freezed package are meant to be gitignored. Maybe this can be of some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Websocket Support
3 participants