Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oauth2 token generation #530

Closed
wants to merge 12 commits into from
Closed

Conversation

abhinavs1920
Copy link

PR Description

This pull request implements the core functionalities of the OAuth2 feature, specifically focusing on configuration saving and changes. The implementation utilizes the official Dart OAuth2 package and uses GitHub as the OAuth provider for illustration purposes. The Authorization Code flow type is currently implemented.

As per the last PR #524, I have made changes to my code.

I will be very happy if you would guide me for the improvements I need to do.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with the project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: please replace this line with details on why tests have not been included

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

@abhinavs1920
Copy link
Author

@ashitaprasad please review my PR. Let me know the changes required.

@abhinavs1920 abhinavs1920 changed the title Oauth2 Added Oauth2 token generation Jan 22, 2025
@ashitaprasad
Copy link
Member

The OAuth implementation is currently at a global app level which is not the right approach. Also, the design system is not being followed.
It is recommended you learn more about API Auth for API testing and start with a simpler form of authentication first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OAuth 2.0 authentication
2 participants