Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue #178 (Switch from GET->POST if payload exists) #514

Closed
wants to merge 3 commits into from

Conversation

AB527
Copy link

@AB527 AB527 commented Dec 19, 2024

PR Description

This PR is with respect to the issue #178 . I have resolved this issue and also added the relevant test cases.

The final results are as follows:

Screen.Recording.2024-12-19.005210.mp4

And the test case results:

Screenshot 2024-12-19 154540

Related Issues

Checklist

  • [✅] I have gone through the contributing guide
  • [✅] I have updated my branch and synced it with project main branch before making this PR
  • [✅] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • [✅] Yes
  • No, and this is why: please replace this line with details on why tests have not been included

OS on which you have developed and tested the feature?

  • [✅] Windows
  • macOS
  • Linux

@ashitaprasad
Copy link
Member

You have again sent a PR which removes features from the current main branch.
Delete your fork. Create a new fork. Manually do the changes again in your fork. Verify the changes.
Then raise a new PR.

@AB527
Copy link
Author

AB527 commented Dec 20, 2024

Sorry for the inconvenience. Since I had raised PR before the new commits were made, I thought it wouldn't be a problem. I am new to open source contributions and I hope you will guide me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants