-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposition for fixing CMake procedure #923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvdp1 I installed CMake 3.31.5, and managed to rebuild without problems. I'm wondering if the problem is the generator under your OS Linux Fedora. Do you have Ninja installed? Would you mind double checking by adding The PR looks good to me, would just like to know where the issue comes from as indeed I did not see that problem on Windows or Ubuntu. |
On macOS I get (before this PR):
|
Ok, so it seems the generator added some extra layers. I think we can merge this PR, it is much more robust this way! Thank you @jvdp1 |
Here is a proposition for fixing the compilation with
cmake 3.31.1
introduced by #913 and mentioned in #922Fixes #922
@jalvesz @perazz