-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor documentation regarding consistency #503
refactor documentation regarding consistency #503
Conversation
added section `Introduction` added section `Procedures and methods provided` adjusted level of procedure description
Thanks, @JHenneberg and good question. I don't think we have a template for this, and I think we should. @jvdp1 @ivan-pi what did you use as reference when creating the first spec docs in stdlib? |
Hi. I used the Fortran standard doc
Le mar. 31 août 2021 à 18:40, Milan Curcic ***@***.***> a
écrit :
… Thanks, @JHenneberg <https://github.com/JHenneberg> and good question. I
don't think we have a template for this, and I think we should. @jvdp1
<https://github.com/jvdp1> @ivan-pi <https://github.com/ivan-pi> what did
you use as reference when creating the first spec docs in stdlib?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#503 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5RO7HD4Q5OEIFDICCVSETT7UAYBANCNFSM5DEJOQYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, thanks @JHenneberg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing, looks good to me.
@JHenneberg I see WIP in the title--would you like to work more on this PR or should we merge it? |
I wanted to work more on it, but now that there is a discussion going on about the spec_template.md it can be merged, because depending what changes might come it could be double the work. |
How about we add 2 small sections in documentation with the name For example, if a person is using or if a person is using Also, sometimes Fortan throws bad errors, so the documentation can provided some possible ways in which a user might have added errors when using a function. |
Also, removing those trailing double spaces which looked useless make .md file (markdown) look different: taken from https://stdlib.fortran-lang.org/page/specs/stdlib_string_type.html#to_title-function. in .md files (markdown): Previously with double spaces this used to look like this: taken from GitHub and NOT from https://stdlib.fortran-lang.org To try out one can use https://www.markdowntutorial.com or some other website but the point is that markdown files look different when viewed on GitHub from what they do when we are editing them on some editor like VS Code. Those single spaces before Enter, I never knew, turned out to be redundant. |
@@ -1350,7 +1350,7 @@ program demo | |||
use stdlib_string_type | |||
implicit none | |||
type(string_type) :: string, reverse_string | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These double spaces
are redundant because the two Enters
did the job here of creating a new line
Ok Interesting. Did not know about this Can you add this information to #504 ? And this too:
|
Could someone link the file to where the documentation standard is desribed?
I was reading through some documents in
doc/specs
and realised differenced between those documents.Mostly the layout looks like following:
stdlib_ascii.md
and a lot of other modules are following this convention, but some do not. Sometimes the order of the subsections describing the procedures are different or some subsections are missing. In other documents the hierarchy level is changed. Do you feel there is a need to address this issues? Should this be continued to be discussed in #181 ?