MbedTLS Reference counted instead of lifetimes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
reviewed
Nov 19, 2020
AdrianCX
force-pushed
the
acruceru/mbed-reference-counted
branch
4 times, most recently
from
6e41bdc to
2ce3aa1
Compare
jethrogb
reviewed
Nov 26, 2020
AdrianCX
force-pushed
the
acruceru/mbed-reference-counted
branch
2 times, most recently
from
0be7829 to
cd9eb8e
Compare
jethrogb
reviewed
Dec 1, 2020
This was referenced Dec 1, 2020
jethrogb
reviewed
Dec 3, 2020
jethrogb
reviewed
Dec 3, 2020
AdrianCX
force-pushed
the
acruceru/mbed-reference-counted
branch
4 times, most recently
from
f741aeb to
1715f09
Compare
AdrianCX
force-pushed
the
acruceru/mbed-reference-counted
branch
from
3344b8d to
241be71
Compare
jethrogb
reviewed
Dec 14, 2020
This was referenced Dec 14, 2020
jethrogb
reviewed
Dec 15, 2020
Arc Changes: - Each Config/Context/... will hold Arcs towards items it holds pointers to. - This forces objects to live as long as needed, once no longer used they get destroyed by reference counting. This allows passing the objects to multiple threads without worrying about lifetime. I've also added notes why classes are Sync where used. Let me know if I missed any classes. Usage example of an intermediate mbed-hyper integration is at: - https://github.com/fortanix/rust-mbedtls/tree/acruceru/wip-mbed-hyper-v2/mbedtls-hyper/examples/integrations There I added a crate to wrap hyper - similar to native-tls. (that will be moved to native-tls layer soon) That crate can be considered an integration test that I will raise a separate PR for.
AdrianCX
force-pushed
the
acruceru/mbed-reference-counted
branch
from
65ea801 to
afecf09
Compare
|
bors try |
tryBuild succeeded: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2020
128: MbedTLS Reference counted instead of lifetimes r=jethrogb a=AdrianCX Moving from referene counting allows simpler move to native-tls / hyper. Arc Changes: - Each Config/Context/... will hold Arcs towards items it holds pointers to. - This forces objects to live as long as needed, once no longer used they get destroyed by reference counting. This allows passing the objects to multiple threads without worrying about lifetime. I've also added notes why classes are Sync where used. Let me know if I missed any classes. Usage example of an intermediate mbed-hyper integration is at: - https://github.com/fortanix/rust-mbedtls/tree/acruceru/wip-mbed-hyper-v2/mbedtls-hyper/examples/integrations There I added a crate to wrap hyper - similar to native-tls. (that will be moved to native-tls layer soon) That crate can be considered an integration test that I will raise a separate PR for. Edit: Changes after initial review: - Added forward_mbedtls_calloc / forward_mbedtls_free functions so we can pass certificates to and from mbedtls without allocator mismatches/corruptions. - Switched to MbedtlsList<Certificate> and Certificate. A MbedtlsBox is pending for this PR as well. - Fixed most comments. Still pending: - Update define! macros - Add MbedtlsBox<Certificate> Fixes #1 Partial progress on #3 Fixes #4 Fixes #8 Partially addresses #9 Co-authored-by: Adrian Cruceru <[email protected]>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
mcr
pushed a commit
to mcr/rust-mbedtls
that referenced
this pull request
Aug 10, 2023
Gets rid of synthetic_error, and makes the various send_* methods return `Result<Response, Error>`. Introduces a new error type "HTTP", which represents an error due to status codes 4xx or 5xx. The HTTP error type contains a boxed Response, so users can read the actual response if they want. Adds an `error_for_status` setting to disable the functionality of treating 4xx and 5xx as errors. Adds .unwrap() to a lot of tests. Fixes fortanix#128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from referene counting allows simpler move to native-tls / hyper.
Arc Changes:
This allows passing the objects to multiple threads without worrying about lifetime.
I've also added notes why classes are Sync where used. Let me know if I missed any classes.
Usage example of an intermediate mbed-hyper integration is at:
There I added a crate to wrap hyper - similar to native-tls. (that will be moved to native-tls layer soon)
That crate can be considered an integration test that I will raise a separate PR for.
Edit:
Changes after initial review:
Still pending:
Fixes #1
Partial progress on #3
Fixes #4
Fixes #8
Partially addresses #9