Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Сhain id from bot config for logs #850

Merged
merged 11 commits into from
Feb 9, 2024
Merged

Сhain id from bot config for logs #850

merged 11 commits into from
Feb 9, 2024

Conversation

dkeysil
Copy link
Contributor

@dkeysil dkeysil commented Feb 6, 2024 •
edited
Loading

  • Use since in docker client to get logs only from the past interval time
  • Use tail to limit number of lines (and increase this parameter)
  • Add ChainID from agent config instead of Scanner's ChainID
  • Fix prefix bytes removal from docker logs

@dkeysil dkeysil changed the title Kisel/forta 1563 chain id from bot config for logs Сhain id from bot config for logs Feb 6, 2024
@dkeysil dkeysil force-pushed the kisel/forta-1563-chain-id-from-bot-config-for-logs branch from 20d21cb to 38568b5 Compare February 7, 2024 11:59
@dkeysil dkeysil requested review from canercidam and aomerk February 7, 2024 13:35
@dkeysil dkeysil force-pushed the kisel/forta-1563-chain-id-from-bot-config-for-logs branch from 4206746 to 13fcbdd Compare February 7, 2024 13:37
canercidam
canercidam requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@canercidam canercidam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We could improve the mutex usage a little.

services/components/registry/registry.go Outdated Show resolved Hide resolved
services/components/registry/registry.go Outdated Show resolved Hide resolved
clients/docker/client.go Show resolved Hide resolved
clients/docker/client.go Show resolved Hide resolved
@dkeysil dkeysil requested a review from canercidam February 8, 2024 08:44
@dkeysil dkeysil merged commit c3c29f8 into master Feb 9, 2024
3 checks passed
@dkeysil dkeysil deleted the kisel/forta-1563-chain-id-from-bot-config-for-logs branch February 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canercidam canercidam canercidam approved these changes

@aomerk aomerk Awaiting requested review from aomerk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkeysil @canercidam