Implement v2 sharding and chain ID detection #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canercidam
force-pushed
the
caner/forta-1405-inject-chainshard-config-into-container
branch
from
4e99495 to
b79ee72
Compare
aomerk
reviewed
Dec 19, 2023
| keyDefaultChainSetting = "default" | ||
| defaultShardID = 0 | ||
| minShardCount = 1 | ||
| defaultTargetCount = 3 |
There was a problem hiding this comment.
FYI - default target is 6 https://github.com/forta-network/forta-assigner/blob/9d2091deb6ab51ec0d1657e6607206854afadc39/domain/chain.go#L8
Though I think I want the assigner to switch to 3, but still, it's 6 for now
There was a problem hiding this comment.
If we deploy a v2 bot in dev right now, we get 3 assignments, not 6, right?
There was a problem hiding this comment.
We need to be crystal clear that the default is always 3 for every scanned source - can't afford to default to 6 for an unknown reason. Chain ID and shard ID detection is strictly based on how many assignments are expected.
Base automatically changed from
caner/forta-1403-scan-node-needs-to-understand-the-new-version-flag-in-bot
to
master
December 20, 2023 08:16
canercidam
deleted the
caner/forta-1405-inject-chainshard-config-into-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.