contrib: setup_templates: clean up the cloud-init configuration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cloud-init scripts should be kept as minimalistic as possible, because they are (compared to jobs run via GitHub) hard to debug. The ssh service is not reachable from the outside, due to the NAT-ing done by qemu slirp/user networking. We can thus leave the decision to disable/uninstall ssh to the setup code in the jobs.
The service ordering should be handled by systemd alone and not via some hacky wait scripts as well. If this breaks for some reason we need to fix it properly.
This results in the file being written unconditionally on every boot. This also means that the file in cloud-init and the one in the machine will not become out of sync. The drawback is that we need to systemctl deamon-reload on every boot now, which should however be okay performance-wise.
This results in the file being written unconditionally on every boot. This also means that the file in cloud-init and the one in the machine will not become out of sync. The drawback is that we need to systemctl deamon-reload on every boot now, which should however be okay performance-wise.
This feels a bit cleaner than calling mount in a service unit.
hnez
force-pushed
the
topic/cloud-init-cleanup
branch
from
9ff115c to
2fc597f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up various aspects of the default
cloud-initconfiguration.I will leave this as a draft until I get around to test it.