Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WIP: ingres: webhook: use hyper instead of the ad-hoc http implementa…
…tion In the future we will likely want to do more things via HTTP, namely serving prometheus metrics, providing a status page or allowing the jobs inside of the machines to upload artifacts. Growing a custom web server to do all of these things would be possible, but not really a reasonable thing to do. Instead use the hyper crate as a HTTP server implementation for the webhook endpoint. Using hyper as a server crate has the benefit of already being in our dependencies via the octocrab crate. As far as I can tell this is however the only benefit of hyper (in our low-traffic usecase at least). The interface seems to be designed by a committee of drunk lawyers that are payed by the number of crates they split their completely bonkers traits into, as a result of this it is about as ergononic as a designer chair. The documentation is strewn all over the place between all these crates and the hyper doc writers have, in all their wisdom, included `#[doc(hidden)]`s in their documentation, making it even less navigable. Maybe what's hidden is proprietary knowledge that they can bill extra for. I hated any minute working with hyper so far. We are in for a good time.
- Loading branch information