Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-4235 Fixed confirmation dialog popping up when the data is empty … #5413

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

antonSoftensity
Copy link
Contributor

…in EditGrid

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-4235

Description

Fixed the case when confirmation dialog showed up when the EditGrid row was empty

How has this PR been tested?

Tested locally

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@TanyaGashtold TanyaGashtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

@TanyaGashtold TanyaGashtold merged commit 1f2b9b7 into master Dec 8, 2023
4 checks passed
lane-formio pushed a commit that referenced this pull request Dec 22, 2023
#5413)

* FIO-4235 Fixed confirmation dialog popping up when the data is empty in EditGrid

* FIO-4235 Fixed more cases when confirmation dialog wasn't showing up for EditGrid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants