Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7525: fixed an issue where new conditional logic based on select boxes does not work #5400

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Nov 9, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7525

Description

What changed?

changed condition for execution of conditional logic based on select boxes

How has this PR been tested?

Manually + test added

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@alexandraRamanenka
Copy link
Contributor

Looks like it has a conflict in the file with tests

@travist
Copy link
Member

travist commented Jan 31, 2024

👍

@travist travist merged commit 29bed8f into master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants