Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8273 fixed advanced logic for data components #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HannaKurban
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8273

Description

Fixed the behavior when the properties of the original component changed when the logic was triggered, which led to a change in all nested components inside the Data components
Previously If the logic was triggered, then the properties of the original component changed. For example, there is a DataGrid component in the form. Inside the DataGrid component, there is a Text Field component with logic, when triggered, the required property for the textField component is added. For the DataGrid Component, the evaluate Process is executed row by row. Therefore, if validate.required = true is set in any row for TextField after triggering the logic, then this property changes the original component and is applied to all following TextField rows. This issue has been fixed by cloning the original component.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Automated tests have been added. All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant